-
Notifications
You must be signed in to change notification settings - Fork 14
📝 [maykinmedia/open-api-framework#205] Describe version policy + supported versions in documentation #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 84.98% 84.98%
=======================================
Files 141 141
Lines 2843 2843
Branches 224 224
=======================================
Hits 2416 2416
Misses 375 375
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5bdfc13 to
33abf75
Compare
c0ff3dd to
d6a091a
Compare
d6a091a to
febc8a9
Compare
stevenbal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you apply the same changes
b668e48 to
50f0b5e
Compare
|
| Branch | feature/add-version-policy |
| Testbed | ubuntu-24.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result | Latency milliseconds (ms) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 22.97 ms(+5.18%)Baseline: 21.84 ms | 22.93 ms (100.17%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type | 📈 view plot 🚷 view threshold | 125.46 ms(+3.35%)Baseline: 121.39 ms | 127.46 ms (98.43%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 22.97 ms(+5.18%)Baseline: 21.84 ms | 22.93 ms (100.17%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1 | 📈 view plot 🚷 view threshold | 314.51 ms(+3.14%)Baseline: 304.94 ms | 320.18 ms (98.23%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5 | 📈 view plot 🚷 view threshold | 312.03 ms(+2.37%)Baseline: 304.81 ms | 320.05 ms (97.50%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20 | 📈 view plot 🚷 view threshold | 133.32 ms(+1.75%)Baseline: 131.03 ms | 137.58 ms (96.91%) |
stevenbal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor wording issue remaining, looks good otherwise.
@danielmursa-dev could you apply the same suggestions to Open Zaak and the other open PRs for this issue?
…orted versions in documentation
50f0b5e to
3a27527
Compare
Partially closes maykinmedia/open-api-framework#205